Prevent stdout/stderr capture on headless mode #3441
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging tests got much harder since recent stdout/stderr capturing changes, since we can no longer print inside them. The prints get captured by Textual, meaning they don't make it as far as the pytest output.
I think when running apps headless, we want to allow prints to make it through, but I may be missing broader context on the print capturing changes that went in.
I've confirmed allows the
print
output to make it to the pytest output as expected.@willmcgugan thoughts on this?
Edit - a test is failing but that's expected. I won't look to resolve that test until we agree on direction for this.