Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Tree(disabled=True) breaking app #3409

Merged
merged 2 commits into from
Sep 27, 2023
Merged

fix Tree(disabled=True) breaking app #3409

merged 2 commits into from
Sep 27, 2023

Conversation

joshbduncan
Copy link
Contributor

@joshbduncan joshbduncan commented Sep 27, 2023 •
edited
Loading

Fixes #3407 where Tree widget initialized/mounted with disabled=True would break its parent app

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@joshbduncan
fix Tree(disabled=True) breaking app
584f3fc 
Fixes Textualize#3407 where `Tree` widget initialized/mounted with `disabled=True`
would break it's parent app
@joshbduncan
fix type error for GenericAlias
6698bbb
@joshbduncan joshbduncan mentioned this pull request Sep 27, 2023
Closed
@davep davep added the bug Something isn't working label Sep 27, 2023
davep
davep approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@davep davep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thanks for reporting and fixing!

@davep davep merged commit fb81ee9 into Textualize:main Sep 27, 2023
22 checks passed
@joshbduncan joshbduncan deleted the disabled-trees branch September 27, 2023 15:57
@TomJGooding TomJGooding mentioned this pull request Sep 22, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davep davep davep approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tree disabled=True breaks when setting at initialization
2 participants
@joshbduncan @davep