TextArea test fixes for 3.7 #3397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrenburns
requested review from
davep,
willmcgugan and
rodrigogiraoserrao
rodrigogiraoserrao
approved these changes
Sep 25, 2023
Co-authored-by: Rodrigo Girão Serrão <[email protected]>
rodrigogiraoserrao
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
I'm adding these 3 suggestions because you accepted the last one but didn't update the other marks @darrenburns
Co-authored-by: Rodrigo Girão Serrão <[email protected]>
Co-authored-by: Rodrigo Girão Serrão <[email protected]>
Co-authored-by: Rodrigo Girão Serrão <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests were failing on 3.7 so we've skipped them.
Unfortunately this makes updating snapshot tests awkward if you're running 3.7.