Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable new rows can have auto height. #3213

Merged
merged 15 commits into from
Sep 20, 2023
Merged

DataTable new rows can have auto height. #3213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a09773f
DataTable new rows can have auto height.
rodrigogiraoserrao Aug 31, 2023
c3904e5
Test auto height computation in DataTable.add_row
rodrigogiraoserrao Aug 31, 2023
65aaf39
Add snapshot test for add_row height=None.
rodrigogiraoserrao Aug 31, 2023
faf0392
Extract some styles logic into auxiliary methods.
rodrigogiraoserrao Sep 4, 2023
c9ae50d
Cache auxiliary cell renderings.
rodrigogiraoserrao Sep 4, 2023
81d94fa
Fix test import.
rodrigogiraoserrao Sep 4, 2023
5fbeeec
Merge branch 'main' into auto-height-datatable-row
rodrigogiraoserrao Sep 4, 2023
35ae591
Set row height to 0 when adding auto-height row.
rodrigogiraoserrao Sep 5, 2023
2336757
Remove superfluous cache clear.
rodrigogiraoserrao Sep 6, 2023
2949dad
Fix cache/typing issue.
rodrigogiraoserrao Sep 6, 2023
6fe5f2f
Cache method to compute styles to render cell.
rodrigogiraoserrao Sep 6, 2023
cec81ee
Perform surgery on the datatable cache.
rodrigogiraoserrao Sep 11, 2023
12b2a0a
Improve data table tests.
rodrigogiraoserrao Sep 11, 2023
007008b
Reduce cache size.
rodrigogiraoserrao Sep 15, 2023
2524af4
Clear cache with other caches.
rodrigogiraoserrao Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Callbacks scheduled with `call_next` will now have the same prevented messages as when the callback was scheduled https://github.com/Textualize/textual/pull/3065
- Added `cursor_type` to the `DataTable` constructor.
- Fixed `push_screen` not updating Screen.CSS styles https://github.com/Textualize/textual/issues/3217
- `DataTable.add_row` accepts `height=None` to automatically compute optimal height for a row https://github.com/Textualize/textual/pull/3213

### Fixed

Expand Down
Loading