Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace some borders in default mac terminal. #2770

Closed
wants to merge 1 commit into from
Closed

Replace some borders in default mac terminal. #2770

wants to merge 1 commit into from

Conversation

rodrigogiraoserrao
Copy link
Contributor

Related issues: #2658

Replaces 3 terribly-looking borders with decent-looking alternatives.

What all borders look like in the default mac terminal with the default font Menlo Regular 13:

Untitled

@rodrigogiraoserrao rodrigogiraoserrao self-assigned this Jun 12, 2023
@rodrigogiraoserrao rodrigogiraoserrao added the enhancement New feature or request label Jun 12, 2023
@rodrigogiraoserrao
Copy link
Contributor Author

We're parking this for now.
A possible fix seems to be to set the line spacing to a smaller value.

@willmcgugan
Copy link
Collaborator

Closing in favor of a new FAQ entry. https://github.com/Textualize/textual/blob/main/FAQ.md#why-doesn't-textual-look-good-on-macos

@rodrigogiraoserrao rodrigogiraoserrao deleted the mac-borders branch September 19, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan Awaiting requested review from willmcgugan

Assignees

@rodrigogiraoserrao rodrigogiraoserrao

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodrigogiraoserrao @willmcgugan