Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the widget moving tests more granular and add more tests #2522

Merged
merged 1 commit into from
May 9, 2023
Merged

Make the widget moving tests more granular and add more tests #2522

merged 1 commit into from
May 9, 2023

Conversation

davep
Copy link
Contributor

@davep davep commented May 9, 2023

Adds two (currently xfail) tests to illustrate #1743

@davep davep self-assigned this May 9, 2023
@davep davep added bug Something isn't working enhancement New feature or request Task labels May 9, 2023
rodrigogiraoserrao
rodrigogiraoserrao approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@rodrigogiraoserrao rodrigogiraoserrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this :)

@davep davep merged commit 8855471 into Textualize:main May 9, 2023
@davep davep deleted the move-widget-enhanced-testing branch May 30, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigogiraoserrao rodrigogiraoserrao rodrigogiraoserrao approved these changes

@willmcgugan willmcgugan Awaiting requested review from willmcgugan

@darrenburns darrenburns Awaiting requested review from darrenburns

Assignees

@davep davep

Labels
bug Something isn't working enhancement New feature or request Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davep @rodrigogiraoserrao