Remove ToggleButton styling switcheroo

Textualize · Oct 14, 2024 · 7e6911b · 7e6911b
1 parent c0e3d69
commit 7e6911b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 21 deletions.
diff --git a/src/textual/widgets/_radio_set.py b/src/textual/widgets/_radio_set.py
@@ -36,12 +36,17 @@ class RadioSet(VerticalScroll, can_focus=True, can_focus_children=False):
         & > RadioButton {
             background: transparent;
             border: none;
-            padding: 0 1;
+            padding: 0;
         }
 
         & > RadioButton.-selected {
             color: $text;
             background: $highlight-cursor-blurred;
+
+            & > .toggle--button {
+                color: $surface;
+                background: $foreground 15%;
+            }
         }
 
         & .toggle--button {
@@ -59,29 +64,19 @@ class RadioSet(VerticalScroll, can_focus=True, can_focus_children=False):
             */
             border: tall $border;
 
-            & .toggle--button {
-                color: $surface;
-                background: $panel-lighten-1;
-            }
-
             & > RadioButton.-selected {
                 color: $text;
                 background: $highlight-cursor;
-
-                & > .toggle--label {
-                    background: $highlight-cursor;
+                & > .toggle--button {
+                    color: $surface;
+                    background: $panel-lighten-1;
                 }
-
                 &.-on > .toggle--button {
                     color: $success;
                     background: $panel-lighten-1;
                 }
             }
 
-            & ToggleButton.-selected > .toggle--button {
-                color: $surface;
-                background: $panel-lighten-1;
-            }
         }
     }
     """

diff --git a/src/textual/widgets/_toggle_button.py b/src/textual/widgets/_toggle_button.py
@@ -191,13 +191,6 @@ def _button(self) -> Text:
         # Grab the button style.
         button_style = self.get_component_rich_style("toggle--button")
 
-        # If the button is off, we're going to do a bit of a switcharound to
-        # make it look like it's a "cutout".
-        if not self.value:
-            button_style += Style.from_color(
-                self.background_colors[1].rich_color, button_style.bgcolor
-            )
-
         # Building the style for the side characters. Note that this is
         # sensitive to the type of character used, so pay attention to
         # BUTTON_LEFT and BUTTON_RIGHT.