Merge pull request #4921 from Textualize/remove-classic-footer

Remove classic footer
Textualize · Aug 22, 2024 · 0116cd2 · 0116cd2
2 parents 5573697 + 8f37886
commit 0116cd2
Show file tree

Hide file tree

Showing 11 changed files with 2 additions and 278 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -30,6 +30,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Keys such as escape and space are now displayed in lower case in footer https://github.com/Textualize/textual/pull/4876
 - Changed default command palette binding to `ctrl+p` https://github.com/Textualize/textual/pull/4867
 - Removed `ctrl_to_caret` and `upper_case_keys` from Footer. These can be implemented in `App.get_key_display`.
+- Breaking change: Removed ClassicFooter (please use new Footer widget) https://github.com/Textualize/textual/pull/4921
 
 ### Fixed
 

diff --git a/docs/examples/widgets/classic_footer.py b/docs/examples/widgets/classic_footer.py
diff --git a/docs/widget_gallery.md b/docs/widget_gallery.md
@@ -34,20 +34,6 @@ A classic checkbox control.
 ```{.textual path="docs/examples/widgets/checkbox.py"}
 ```
 
-## ClassicFooter
-
-The original Footer widget.
-
-!!! warning
-
-    This has been replaced by [`Footer`](#footer), and will be removed in Textual v1.0
-
-[ClassicFooter reference](./widgets/classic_footer.md){ .md-button .md-button--primary }
-
-```{.textual path="docs/examples/widgets/classic_footer.py" columns="70" lines="12"}
-```
-
-
 
 ## Collapsible
 

diff --git a/docs/widgets/classic_footer.md b/docs/widgets/classic_footer.md
diff --git a/docs/widgets/footer.md b/docs/widgets/footer.md
@@ -2,9 +2,6 @@
 
 !!! tip "Added in version 0.63.0"
 
-    This is a second iteration of the Footer.
-    The version prior to 0.63.0 is available as [ClassicFooter](./classic_footer.md) to help with backwards compatibility, but will be removed in v1.0.
-
 A simple footer widget which is docked to the bottom of its parent container. Displays
 available keybindings for the currently focused widget.
 

diff --git a/mkdocs-nav.yml b/mkdocs-nav.yml
@@ -141,7 +141,6 @@ nav:
       - Widgets:
           - "widgets/button.md"
           - "widgets/checkbox.md"
-          - "widgets/classic_footer.md"
           - "widgets/collapsible.md"
           - "widgets/content_switcher.md"
           - "widgets/data_table.md"

diff --git a/src/textual/widgets/__init__.py b/src/textual/widgets/__init__.py
@@ -12,7 +12,6 @@
     from ..widget import Widget
     from ._button import Button
     from ._checkbox import Checkbox
-    from ._classic_footer import ClassicFooter
     from ._collapsible import Collapsible
     from ._content_switcher import ContentSwitcher
     from ._data_table import DataTable
@@ -52,7 +51,6 @@
 __all__ = [
     "Button",
     "Checkbox",
-    "ClassicFooter",
     "Collapsible",
     "ContentSwitcher",
     "DataTable",

diff --git a/src/textual/widgets/_classic_footer.py b/src/textual/widgets/_classic_footer.py
diff --git a/src/textual/widgets/_footer.py b/src/textual/widgets/_footer.py
@@ -176,8 +176,6 @@ def __init__(
             id: The ID of the widget in the DOM.
             classes: The CSS classes for the widget.
             disabled: Whether the widget is disabled or not.
-            upper_case_keys: Show the keys in upper case.
-            ctrl_to_caret: Show `ctrl+` as `^`.
             show_command_palette: Show key binding to command palette, on the right of the footer.
         """
         super().__init__(

diff --git a/tests/snapshot_tests/snapshot_apps/auto_width_input.py b/tests/snapshot_tests/snapshot_apps/auto_width_input.py
@@ -1,5 +1,5 @@
 from textual.app import App, ComposeResult
-from textual.widgets import Header, Footer, Input, ClassicFooter
+from textual.widgets import Header, Footer, Input
 
 
 class InputWidthAutoApp(App[None]):

diff --git a/tests/snapshot_tests/snapshot_apps/footer_classic_styling.py b/tests/snapshot_tests/snapshot_apps/footer_classic_styling.py
@@ -39,11 +39,6 @@ class ClassicFooterStylingApp(App):
     def compose(self) -> ComposeResult:
         yield Footer()
 
-    def on_mount(self) -> None:
-        footer = self.query_one(Footer)
-        footer.upper_case_keys = True
-        footer.ctrl_to_caret = False
-
 
 if __name__ == "__main__":
     app = ClassicFooterStylingApp()