Added __lt__ function to Text class to enable sort functionality #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmcgugan
requested changes
Jul 29, 2023
rich/text.py
Outdated
| return self.plain < other | ||
| elif isinstance(other, Text): | ||
| return self.plain < other.plain | ||
| return False |
There was a problem hiding this comment.
This should return NotImplemeted rather than False.
There was a problem hiding this comment.
Done. I originally did this as a shortcut for comparing with None, but that is bad form. I also removed the test cases accordingly.
|
Probably not needed now. The DataTable has grown more sorting functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
Basic change to enable sort functionality in Textual DataTable. Copied structure of contains function. Textualize/textual/issues/2261
Please hold... I need to add the gt function as well to cover both "str < Text" and "Text < str". -- Done.