feat - discrete cookie return #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit tests pass, but it needs testing in the electron app. |
|
we can add a test for the use case where cookies werent set earlier with redirects |
|
New test passes. |
|
lgtm, i'll test with all the platforms once |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lands an internal time-based cookie jar.
The motivation behind this is that we cannot set a dedicated jar for each request. And recreating the client for each request seems wasteful.
Time-based cookie jar track cookies by time to fetch cookies since request time.
This is rather crude, but it works, and be later improved when better support lands in request: seanmonstar/reqwest#353