-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Document how to add new overlays in the dtbo.img #150
Merged
praneethbajjuri
merged 4 commits into
TexasInstruments:master
from
makohoek:android-kernel-dtbo
Jan 8, 2025
Merged
Android: Document how to add new overlays in the dtbo.img #150
praneethbajjuri
merged 4 commits into
TexasInstruments:master
from
makohoek:android-kernel-dtbo
Jan 8, 2025
+116
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit f8c988a ("feat(android): Move ota guide to Foundational_Components") moved the ota guides to the generic Android documentation (Foundational Components). However, the removed file is still listed in the device-specific TOCs. This generates a build warning: WARNING: toctree contains reference to nonexisting document 'devices/AM62X/android/ Fix the warning by removing the nonexisting OTA document. Fixes: f8c988a ("feat(android): Move ota guide to Foundational_Components") Signed-off-by: Mattijs Korpershoek <[email protected]>
For numbering to behave properly when a new paragraph is inserted, implicit lists should be indented. Reindent the list that describes how to add a new kernel module. Signed-off-by: Mattijs Korpershoek <[email protected]>
makohoek
requested review from
cshilwant,
StaticRocket,
praneethbajjuri,
uditkumarti,
aniket-l and
VeeruPrudhvi
as code owners
January 7, 2025 14:03
StaticRocket
requested changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the formatting nit-picks this seems pretty straightforward
The snippet comes from BUILD.bazel which is in bazel language. According to [1], bazel is supported by pygments. Use it instead of using bash. [1] https://pygments.org/docs/lexers/#pygments.lexers.python.PythonLexer Suggested-by: Randolph Sapp <[email protected]> Signed-off-by: Mattijs Korpershoek <[email protected]>
For Android newcomers, it's not trivial to know how to add new device tree overlays. See [1] Since it's different than the linux SDK, we should document it. Add a section in the kernel guide for this. [1] https://e2e.ti.com/support/processors-group/processors/f/processors-forum/1454200/sk-am62p-lp-sk-am62p-lp-androidautomotive-unable-to-get-the-dsi-port-up-and-running Signed-off-by: Mattijs Korpershoek <[email protected]>
makohoek
force-pushed
the
android-kernel-dtbo
branch
from
January 8, 2025 08:29
9a8aa57
to
d0e2651
Compare
Change in v2:
|
StaticRocket
approved these changes
Jan 8, 2025
vishalmti
approved these changes
Jan 8, 2025
praneethbajjuri
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Android newcomers, it's not trivial to know how to add new device tree
overlays. See [1]
Since it's different than the linux SDK, we should document it.
Add a section in the kernel guide for this.
[1] https://e2e.ti.com/support/processors-group/processors/f/processors-forum/1454200/sk-am62p-lp-sk-am62p-lp-androidautomotive-unable-to-get-the-dsi-port-up-and-running
While at it, also:
Cc: @vishalmti @glaroque