Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add openstreetmap as basemap. #7325

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add openstreetmap as basemap. #7325

wants to merge 2 commits into from
+15 −0

Conversation

na9da
Copy link
Collaborator

@na9da na9da commented Nov 22, 2024

What this PR does

Adds openstreetmap as a basemap.
Sticking with current setup, this would still require change to simple.json in terriamap to use as default basemap.

Test me

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@na9da na9da mentioned this pull request Nov 22, 2024
Open
nf-s
nf-s approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@nf-s nf-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

Just one small thing, can you please make the thumbnail a square so it matches the others

image

Thanks!

@na9da
Copy link
Collaborator Author

na9da commented Nov 22, 2024

Awesome, thanks!

Just one small thing, can you please make the thumbnail a square so it matches the others
image

Thanks!

Yep, also I need to reduce the size of thumbnail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nf-s nf-s nf-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@na9da @nf-s