prettyPrintGtfsEntityField: fix types #7316
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjonsson
referenced
this pull request
Nov 25, 2024
Mainly implements a workaround for error TS2855 that prevents accessing parent class fields as `super.field` [introduced in TS 5.3](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-3.html#checks-for-super-property-accesses-on-instance-fields). In valid JS, super can only be used to access get/set accessors or methods from parent classes that are declared on the prototype, but not instance fields (declared as `x = "something"`). In our case though, traits are declared as getters and not fields, however because we use mapped types to mixin the traits into a class and mapped types does not allow specifying getter/setter variants, TS considers our traits to be fields and raises TS2855. The workaround in this PR defines these erroring traits as getters which seems to convince TS (at least for now) that they are valid accessors eventhough they still are typed using mapped. Hopefully in the future, we get this TS feature implementing [variant accessors for mapped types](microsoft/TypeScript#43826), then we can get rid of this workaround.
na9da
reviewed
Nov 28, 2024
Comment on lines
12
to
13
| const route: string = _get(entity, "vehicle.trip.route_id", ""); | ||
| if (route !== undefined && route.indexOf("_") + 1 > 0) { |
There was a problem hiding this comment.
I think because it is checking for route !== undefined - the safer change would be to type it as route: string | undefined (similar to what you have done below) - instead of passing a default empty string.
There was a problem hiding this comment.
I'm pretty sure I tried that first and it didn't work, but let's go with that for now. Fixed.
Running yarn upgrade gives a type error for something with loadash-es, so add a default value and fix a type annotation to include undefined.
pjonsson
force-pushed
the
fix-loadash-es-types
branch
from
8d0d2aa
to
1aef652
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Running yarn upgrade gives a type error
for something with loadash-es, so add
a default value and fix a type annotation
to include undefined.
Test me
I believe this is tested by CI.
Checklist
doc/.