CJS to ESM #7311
Draft
CJS to ESM #7311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are files from TerriaJS V7 not referenced anywhere else. Some of these might be useful if we want to port them to v8 in the future. If that's the case please refer to https://github.com/terriajs/terriajs/tree/terriajs7
This requires, in some places: - simply swapping require with import - creating a stub .d.ts module definition in lib/ThirdParty - updating the library to get new bundled type definitions - file-saver - react-responsive - or adding @types/x as dependency - @types/proj4 Remaining require() imports are all for static assets or web workers which can be fixed when upgrading to webpack 5.
It is redundant when using typescript.
pjonsson
reviewed
Nov 20, 2024
| @@ -113,7 +113,7 @@ | |||
| "dompurify": "^2.3.3", | |||
| "fetch-mock": "^9.11.0", | |||
| "file-loader": "^3.0.1", | |||
| "file-saver": "^1.3.8", | |||
| "file-saver": "^2.0.4", | |||
There was a problem hiding this comment.
There is a file-saver 2.0.5 released 4 years ago, is there a reason to not bump to that version?
pjonsson
reviewed
Nov 20, 2024
| @@ -195,6 +195,7 @@ | |||
| "@babel/plugin-syntax-dynamic-import": "^7.8.3", | |||
| "@types/dateformat": "^3.0.1", | |||
| "@types/node": "^18.15.11", | |||
| "@types/proj4": "^2.5.5", | |||
There was a problem hiding this comment.
My understanding is that the type annotations are required by tsc, so without them yarn gulp release will fail. Does yarn gulp release work for an external repository, like TerriaMap, if @types/proj4 is a devDependency here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Convert CJS modules to ESM.
Required for #6998
Depends on: https://github.com/terriajs/terriamap/tree/cjs-to-esm
TODO:
What this PR does:
Removes stale CJS files that are no longer used (395d3b9)
Convert CJS style
module.exportsto ESM styleexport default ...(7129b24)Convert CJS require() to ESM import statements. (30654f1)
This requires, in some places:
file-saverreact-responsive@types/proj4Remaining require() imports are all for static assets or web workers which can be fixed when upgrading to webpack 5.
Remove
use strictdeclaration for.tsx?files.Test me
Test http://ci.terria.io/cjs-to-esm
Checklist
doc/.