Update style-loader/mini-css-extract-plugin #7210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjonsson
commented
Jun 23, 2024
| @@ -28,7 +28,6 @@ module.exports = function () { | |||
| plugins: [ | |||
| new MiniCssExtractPlugin({ | |||
| filename: "TerriaJS.css", | |||
There was a problem hiding this comment.
The 1.3.0 release adds checking of unknown options. I cannot find anything about the disable option in the release notes of mini-css-extract-plugin for any version, so I assume it is some leftover from elsewhere that should be removed.
Update style-loader and mini-css-extract-plugin to the latest versions that are compatible with webpack 4. The mini-css-extract-plugin release notes recommend upgrading to style-loader 2.0.0 to avoid issues with esModule, so that is why both are updated in the same commit. The release notes for mini-css-extract-plugin 1.x mention webpack 5 compatibility fixes, so this update should simplify upgrading to webpack 5 when that time comes.
pjonsson
force-pushed
the
update-mini-css-extract
branch
from
f13207b
to
07c02ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Update style-loader and mini-css-extract-plugin
to the latest versions that are compatible
with webpack 4. The mini-css-extract-plugin
release notes recommend upgrading to style-loader
2.0.0 to avoid issues with esModule, so that
is why both are updated in the same commit.
The release notes for mini-css-extract-plugin 1.x
mention webpack 5 compatibility fixes, so this
update should simplify upgrading to webpack 5
when that time comes.
Test me
I'm guessing this is tested by CI?
Checklist
doc/.