Update to ESLint 8.57.0 #7150
Draft
Update to ESLint 8.57.0 #7150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjonsson
force-pushed
the
update-eslint
branch
2 times, most recently
from
91744ef
to
8b68797
Compare
pjonsson
force-pushed
the
update-eslint
branch
2 times, most recently
from
70990a7
to
71b1a79
Compare
pjonsson
force-pushed
the
update-eslint
branch
from
71b1a79
to
5271d8c
Compare
4 tasks
pjonsson
force-pushed
the
update-eslint
branch
from
5271d8c
to
2e6e44a
Compare
|
@na9da this PR doesn't make anything worse than it is currently, and doesn't affect the "terriajs binary" so it is low risk. I assume there isn't a policy against using a newer ESLint on the code base, so is there anything preventing this from getting merged? |
This is in preparation for migrating to the flat format in ESLint 9.
pjonsson
force-pushed
the
update-eslint
branch
from
2e6e44a
to
4afd82c
Compare
|
Just noticed they had renamed the recommended rules for the typescript-eslint plugin. Re-enabling the recommended rules makes this no longer pass, so marking this PR as draft for now, and will make separate PRs of the fixes. To start with, this depends on #7323. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Renames .eslintrc to .eslintrc.js and bumps ESLint to 8.57.0.
This PR will not pass before #7148 and #7149 are merged and this is rebased on top of that.
Test me
Verify that the three added
no-unsafe-optional-chainingignores are safe.Checklist
doc/.