Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to webpack-dev-server 4.15.2 #7142

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented May 4, 2024

What this PR does

This fixes security issues
in dependencies.

This also requires updating webpack-cli
to version 4, so use the latest version
available.

Test me

I think this is tested by CI?

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@na9da
Copy link
Collaborator

na9da commented Nov 14, 2024

@pjonsson - Thanks for the PR.

Are you able to pull in the latest main to fix the conflicts?

This fixes security issues
in dependencies.

This also requires updating webpack-cli
to version 4, so use the latest version
available.
@pjonsson
Copy link
Contributor Author

@na9da rebased to latest main. It's getting late here so I won't be at the computer much longer tonight, is there some other old PR I should rebase?

@na9da na9da merged commit 3bb0063 into TerriaJS:main Nov 19, 2024
6 checks passed
@pjonsson pjonsson deleted the update-webpack-dev-server branch November 19, 2024 09:18
@pjonsson
Copy link
Contributor Author

@na9da Thanks! I'm not sure I understand the intricacies of interdependencies with Terriamap, but I just made a similar PR in that repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants