Fix maximum call stack size exceeded on Math.min/max when creating Charts #6958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ljowen
reviewed
Nov 13, 2023
lib/Core/math.ts
Outdated
There was a problem hiding this comment.
Could we just use Math.min? This method will be faster but I assume calculateDomain get's called only once per series
There was a problem hiding this comment.
Do you mean using Math.min instead of getMin?
Or using Math.min instead of min = nums[len] < min ? nums[len] : min;
We can't use Math.min instead of getMin because of the spread operator in calculateDomain
- Bug: Callstack exceeded in CalculateDomain when switching region aggregation #6941 (comment)
- Sorry I forgot to link this in the ticket before
There was a problem hiding this comment.
Aha! sorry I missed the actual root cause!
Co-authored-by: Lawrence Owen <[email protected]>
ljowen
approved these changes
Nov 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes #6941
I also sneaked in a fix for
MyDataTabshowing a number.Test me
Make sure you test in Chrome (Firefox never had this issue)
Checklist
There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)I've updated relevant documentation indoc/.