Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty styles parameter in WMS #6876

Merged
merged 5 commits into from
Nov 10, 2023
Merged

Fix empty styles parameter in WMS #6876

merged 5 commits into from
Nov 10, 2023

Conversation

nf-s
Copy link
Contributor

@nf-s nf-s commented Sep 7, 2023 •
edited
Loading

What this PR does

Fixes #6849

The WMS spec states that styles must be included on all GetMap and GetFeatureInfo requests

(Instead of reading the specs you can look at #6849)

Test me

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@nf-s nf-s changed the title Wms empty style Fix empty styles parameter in WMS Sep 7, 2023
@nf-s nf-s marked this pull request as ready for review October 11, 2023 10:04
@nf-s nf-s mentioned this pull request Oct 26, 2023
Closed
staffordsmith83
staffordsmith83 approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@staffordsmith83 staffordsmith83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good simple fix, thanks for adding to test too, approved.

@nf-s nf-s merged commit ba0a0e8 into main Nov 10, 2023
6 checks passed
@nf-s nf-s deleted the wms-empty-style branch November 10, 2023 06:18
@nf-s nf-s mentioned this pull request Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staffordsmith83 staffordsmith83 staffordsmith83 approved these changes

Assignees

@staffordsmith83 staffordsmith83

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing styles parameter on wms getfeatureinfo requests
2 participants
@nf-s @staffordsmith83