Fix github action workflows (no builds gets ever uploaded as artifact) #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBossMagnus
changed the title
TheBossMagnus
changed the title
LostLuma
reviewed
Dec 3, 2024
|
thanks! man that workflow was pretty ancient lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current workflow, that hardcoded to upload only for Java 17 on Linux. Since newer Minecraft versions require Java 21, no builds were being uploaded as artifacts.
Additionally, the previous worflow used
strategy: matrixto build the mod across multiple OS and Java versions but in reality it was configured to just Ubuntu 22.04 and Java 21.I removed the matrix things, simplifying the workflow.Updated all the actions version to the latest, this should avid other breakage or at least delay them