Update for 1.21 Pre 2 #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her than the button - Fix update checker not being run when config screen is closed without the Done button
…into 1.21-pre.1
|
I commonly need to update Mod Menu myself for downstream mod development... So I decided to give back my work this time. |
Prospector
reviewed
May 29, 2024
src/main/java/com/terraformersmc/modmenu/gui/ModMenuOptionsScreen.java
Outdated
Show resolved
Hide resolved
Prospector
requested changes
May 29, 2024
src/main/java/com/terraformersmc/modmenu/gui/widget/entries/ModListEntry.java
Outdated
Show resolved
Hide resolved
src/main/java/com/terraformersmc/modmenu/gui/widget/entries/ModListEntry.java
Outdated
Show resolved
Hide resolved
|
Changes made. I can't imagine much more would need to change for the RC cycle or Release. |
haykam821
requested changes
Jun 1, 2024
src/main/java/com/terraformersmc/modmenu/gui/widget/UpdateAvailableBadge.java
Outdated
Show resolved
Hide resolved
src/main/java/com/terraformersmc/modmenu/gui/widget/entries/ModListEntry.java
Outdated
Show resolved
Hide resolved
src/main/java/com/terraformersmc/modmenu/gui/widget/ModListWidget.java
Outdated
Show resolved
Hide resolved
src/main/java/com/terraformersmc/modmenu/gui/widget/ModListWidget.java
Outdated
Show resolved
Hide resolved
src/main/java/com/terraformersmc/modmenu/gui/widget/DescriptionListWidget.java
Outdated
Show resolved
Hide resolved
src/main/java/com/terraformersmc/modmenu/gui/widget/DescriptionListWidget.java
Outdated
Show resolved
Hide resolved
src/main/java/com/terraformersmc/modmenu/gui/ModMenuOptionsScreen.java
Outdated
Show resolved
Hide resolved
…lableBadge.java Co-authored-by: haykam821 <[email protected]>
…dListEntry.java Co-authored-by: haykam821 <[email protected]>
…nListWidget.java Co-authored-by: haykam821 <[email protected]>
…een.java Co-authored-by: haykam821 <[email protected]>
…nListWidget.java Co-authored-by: haykam821 <[email protected]>
…get.java Co-authored-by: haykam821 <[email protected]>
…get.java Co-authored-by: haykam821 <[email protected]>
|
I was hesitant to make the Identifier.of changes because previously the Fabric team changed the Yarn mappings of those about 2 or 3 times. Also, the coding style I have baked into my brain from coding for masa's mods for the last several months, so I had to bake in his coding style into my brain, and have my IDE setup as such. |
haykam821
approved these changes
Jun 4, 2024
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendering and Identifier fixes primarily.