Group mod credits by role instead of bunching them together #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks kind of wrong for some reason, probably because it's using singular words instead of plural words. |
|
I don't think it's really wise to automatically add the s since it won't always work. Consider someone using the word |
LostLuma
force-pushed
the
feature-credit-by-role
branch
from
5592068 to
8b1937a
Compare
LostLuma
force-pushed
the
feature-credit-by-role
branch
from
8b1937a to
135d0e7
Compare
Prospector
reviewed
Apr 22, 2024
|
|
||
| // Add an s to the default untranslated string if it ends in r since this | ||
| // Fixes common role names people use in English (e.g. Author -> Authors) | ||
| var fallback = roleName.endsWith("r") ? roleName + "s" : roleName; |
There was a problem hiding this comment.
this seems a bit strange but I guess it's fine lol. we can remove if it causes issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #652 by grouping the credits by role names (Fabric mod preview / Quilt mod preview).
This is mostly useful on Quilt as we can actually assign contributor roles, but splits it into Authors and Contributors on Fabric.
I was not sure whether role names should be translatable as there is no standard for their names, so they are just displayed literally.