fix: 修复任务未执行节点预览时免渲染表单项中变量仍被渲染问题 #7358 #7383
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lTimej
force-pushed
the
release_humming_bird
branch
from
e01b241
to
a0a36db
Compare
normal-wls
requested changes
May 28, 2024
| @@ -169,7 +169,8 @@ def get_need_render_context_keys(): | |||
| else: | |||
| raise Exception(f"can not preview inputs for node type: {node_type}") | |||
| raw_inputs = {key: info["value"] for key, info in raw_inputs.items()} | |||
| hydrated_context = context.hydrate(deformat=True) | |||
| need_render = pipeline["activities"][node_id]["component"]["inputs"]["job_content"]["need_render"] | |||
There was a problem hiding this comment.
这个处理方式不通用，job_content不是每个 input 都有的，会出现 keyerror
| { | ||
| "${%s}" % key | ||
| for key, val in pipeline["activities"].get(node_id, {}).get("component", {}).get("inputs", {}).items() | ||
| if not val.get("need_render") |
There was a problem hiding this comment.
val.get("need_render") is False，默认渲染，避免历史数据没有need_render字段的情况
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.