Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/turbo mem leak #4079

Closed
wants to merge 1,434 commits into from
Closed

Bugfix/turbo mem leak #4079

wants to merge 1,434 commits into from

Conversation

etkmao
Copy link
Collaborator

@etkmao etkmao commented Oct 18, 2024

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

rocksgong and others added 30 commits August 1, 2022 16:01
…encent#2362)

* chore(github): added templates for crash report issue and it's bot

Co-authored-by: zoomchan-cxj <[email protected]>
…encent#2353)

* docs(web-renderer): add instructions for hippy-react and hippy-vue

* docs(web-renderer): add instructions for hippy-react and hippy-vue

Co-authored-by: Mohannnnn <[email protected]>
etkmao and others added 12 commits December 20, 2023 15:39
Also fixed the issue of missing onPageSelected callbacks upon first entry;

The logic for automatic updates keep same with Android, as follows
1. If the previous item only changes its location,
update the current location and keep the current item displayed.
2. If the previous item does not exist, do not adjust the position,
but keep the current position in the valid range (that is, 0 ~ count-1).
this is a minor fix for feat 'pageIndex of ViewPager auto update after data changes'
…t#3992)

* fix(ios): accuracy of ViewPager's onPageScroll event parameters

* fix(ios): improve accuracy of ViewPager's onPageScroll parameters
Copy link

hippy-service bot commented Oct 18, 2024

Hi, @etkmao. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@tencent-adm
Copy link
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 12 committers have signed the CLA.

✅ siguangli
✅ wwwcg
✅ etkmao
❌ zoomchan-cxj
❌ iPel
❌ ozonelmy
❌ shenchaoran
❌ medns
❌ churchill-zhang
❌ lavnFan
❌ luoyibu
❌ zealotchen0
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.