Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/waterfall image module #4071

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Fix/waterfall image module #4071

merged 3 commits into from
Oct 16, 2024

Conversation

siguangli
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@tencent-adm
Copy link
Member

tencent-adm commented Oct 16, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ siguangli
❌ siguangli2018
You have signed the CLA already but the status is still pending? Let us recheck it.

@hippy-service Hippy Service
Copy link

hippy-service bot commented Oct 16, 2024

Hi, @siguangli. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

iPel
iPel reviewed Oct 16, 2024
View reviewed changes
...droid/src/main/java/com/tencent/mtt/hippy/modules/nativemodules/image/ImageLoaderModule.java
}

private void handleFetchResult(final String url, final Promise promise, @NonNull final ResourceDataHolder dataHolder) {
byte[] bytes = dataHolder.getBytes();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should place after resultCode check

@siguangli siguangli requested a review from iPel October 16, 2024 06:43
@siguangli siguangli merged commit f7da94c into Tencent:main Oct 16, 2024
13 of 17 checks passed
@siguangli siguangli deleted the fix/waterfall_image_module branch October 25, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zealotchen0 zealotchen0 Awaiting requested review from zealotchen0 zealotchen0 is a code owner

@iPel iPel Awaiting requested review from iPel iPel is a code owner

Assignees
No one assigned
Labels
driver: js framework: android renderer: native size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siguangli @tencent-adm @iPel @siguangli2018