feat(ios, android): support loading font dynamically #4067

Cyunong · 2024-10-15T07:01:26Z

Before submitting a new pull request, please make sure:

Test cases have been added/updated/passed for the code you will submit.
Documentation has added or updated.
Commit message is following the Convention Commit guideline with maximum 72 characters.
Squash the repeat code commits, short patches are welcome.

tencent-adm · 2024-10-15T07:01:42Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

hippy-service · 2024-10-15T07:01:48Z

Hi, @Cyunong. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

hippy-service · 2024-10-15T07:02:14Z

After a quick scan, I have approved workflow to run.

SHA: 6a19551

🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators.
🏷️ No need to worry about the status of merge_guard and [gh] pull request merge guard / merge_guard (pull_request_target) checks, once this pull request is met merge requirements, it will be automatically converted to successful status.

renderer/native/android/src/main/java/com/tencent/renderer/component/text/FontLoader.java

framework/ios/module/fontLoader/HippyFontLoaderModule.h

framework/ios/module/fontLoader/HippyFontLoaderModule.mm

renderer/native/ios/renderer/HippyFont.mm

renderer/native/ios/renderer/component/textinput/HippyBaseTextInput.m

hippy-service · 2024-10-15T13:43:15Z

Hi, @Cyunong, I noticed that our reviewers requested changes to this pull request.
When you're done, click the Re-request review button in the right sidebar(shown below) to notify the reviewer.

renderer/native/android/src/main/java/com/tencent/renderer/node/TextVirtualNode.java

renderer/native/android/src/main/java/com/tencent/renderer/component/text/FontLoader.java

...android/src/main/java/com/tencent/mtt/hippy/modules/nativemodules/font/FontLoaderModule.java

renderer/native/android/src/main/java/com/tencent/mtt/hippy/views/textinput/HippyTextInput.java

renderer/native/android/src/main/java/com/tencent/renderer/component/text/FontLoader.java

driver/js/packages/hippy-vue-next/src/runtime/native/index.ts

driver/js/packages/hippy-vue/src/runtime/native.ts

driver/js/packages/hippy-vue-next/src/runtime/native/index.ts

driver/js/packages/hippy-vue-next/src/types/native-modules/font-loader-module.ts

hippy-service · 2024-10-22T07:17:56Z

After a quick scan, I have approved workflow to run.

SHA: 370f9ab

framework/ios/module/fontLoader/HippyFontLoaderModule.h

.../android/connector/renderer/native/src/main/java/com/openhippy/connector/NativeRenderer.java

renderer/native/android/src/main/java/com/tencent/renderer/node/TextVirtualNode.java

renderer/native/android/src/main/java/com/tencent/renderer/NativeRender.java

renderer/native/android/src/main/java/com/tencent/renderer/node/TextVirtualNode.java

renderer/native/android/src/main/java/com/tencent/renderer/NativeRenderer.java

renderer/native/android/src/main/java/com/tencent/mtt/hippy/views/textinput/HippyTextInput.java

renderer/native/android/src/main/java/com/tencent/renderer/node/TextVirtualNode.java

renderer/native/android/src/main/java/com/tencent/renderer/component/text/FontLoader.java

…id to string

…view

renderer/native/android/src/main/java/com/tencent/renderer/node/TextVirtualNode.java

docs/api/style/appearance.md

framework/ios/module/fontLoader/HippyFontLoaderModule.h

modules/vfs/ios/HippyVFSDefines.h

renderer/native/ios/renderer/HippyFont.mm

tests/ios/HippyFontLoaderTest.m

Cyunong requested review from wwwcg, ruifanyuan, siguangli, iPel and zealotchen0 as code owners October 15, 2024 07:01

github-actions bot added framework: android framework: ios driver: js renderer: native labels Oct 15, 2024

github-actions bot added the size: l Denotes a PR that changes 500-999 lines label Oct 15, 2024

rockyIsRK reviewed Oct 15, 2024

View reviewed changes

renderer/native/android/src/main/java/com/tencent/renderer/component/text/FontLoader.java Outdated Show resolved Hide resolved

wwwcg requested changes Oct 15, 2024

View reviewed changes

github-actions bot added size: xl Denotes a PR that changes 1000+ lines doc: pages and removed size: l Denotes a PR that changes 500-999 lines labels Oct 20, 2024

siguangli reviewed Oct 21, 2024

View reviewed changes

zealotchen0 reviewed Oct 21, 2024

View reviewed changes

Cyunong force-pushed the main branch from 712db4e to 370f9ab Compare October 22, 2024 03:27

zealotchen0 previously approved these changes Oct 22, 2024

View reviewed changes

Cyunong dismissed zealotchen0’s stale review via b8c1816 October 22, 2024 13:42

github-actions bot added the module: vfs label Oct 24, 2024

wwwcg reviewed Oct 24, 2024

View reviewed changes

framework/ios/module/fontLoader/HippyFontLoaderModule.h Outdated Show resolved Hide resolved

siguangli reviewed Oct 24, 2024

View reviewed changes

Cyunong force-pushed the main branch from 479af1f to 93c194d Compare October 31, 2024 06:20

feat(ios, android): support loading font dynamically

1ec89cd

Cyunong added 11 commits November 6, 2024 14:15

fix: fix the "given a font name rather than font family" condition

1ce1cb2

feat(doc): add FontLoaderModule

455118c

fix(android): improve the implemention of loading font dynamically

02cf5d6

fix(android, react, vue): add font load state, change resolve from vo…

5490c79

…id to string

fix(ios): remove IO operations from main thread and ensure thread safety

76546e9

fix(ios): fix the "given a font name rather than font family" condition

48e684f

fead(ios, android): support load font from JSbundle

e5624b5

feat(ios): add unitest for FontLoaderModule

074c238

fix(android, ios): improve dynamically load font according to code re…

15e1fdf

…view

fix(doc): add docs for fontUrl in JSBundle path format

68f1af9

fix(android): fix the use of weak reference in font loader

ca9e7c4

Cyunong requested review from wwwcg, zealotchen0 and siguangli November 11, 2024 08:38

siguangli previously approved these changes Nov 11, 2024

View reviewed changes

renderer/native/android/src/main/java/com/tencent/renderer/node/TextVirtualNode.java Outdated Show resolved Hide resolved

wwwcg reviewed Nov 11, 2024

View reviewed changes

Cyunong dismissed siguangli’s stale review via f23b58b November 12, 2024 06:56

Cyunong force-pushed the main branch from 494aca3 to f23b58b Compare November 12, 2024 06:56

github-actions bot added the build: xcode label Nov 12, 2024

Cyunong added 2 commits November 12, 2024 15:21

fix(ios, android): make the code more standardized for font loader

c34cf0d

fix(ios): fix HippyFontLoaderTest using local file

5b38b3f

Cyunong force-pushed the main branch from f23b58b to 0856d5b Compare November 12, 2024 07:26

Cyunong requested review from etkmao and ilikethese as code owners November 12, 2024 07:26

github-actions bot added dom: animation module: android labels Nov 12, 2024

Merge remote-tracking branch 'upstream/main'

cd0a84a

Cyunong force-pushed the main branch from 0856d5b to cd0a84a Compare November 12, 2024 07:42

github-actions bot removed dom: animation module: android labels Nov 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ios, android): support loading font dynamically #4067

feat(ios, android): support loading font dynamically #4067

Cyunong commented Oct 15, 2024

tencent-adm commented Oct 15, 2024 •

edited

Loading

hippy-service bot commented Oct 15, 2024

hippy-service bot commented Oct 15, 2024

hippy-service bot commented Oct 15, 2024

hippy-service bot commented Oct 22, 2024

feat(ios, android): support loading font dynamically #4067

Are you sure you want to change the base?

feat(ios, android): support loading font dynamically #4067

Conversation

Cyunong commented Oct 15, 2024

tencent-adm commented Oct 15, 2024 • edited Loading

hippy-service bot commented Oct 15, 2024

hippy-service bot commented Oct 15, 2024

hippy-service bot commented Oct 15, 2024

hippy-service bot commented Oct 22, 2024

tencent-adm commented Oct 15, 2024 •

edited

Loading