Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ios): add a uiManager getter for UIView #4022

Merged
merged 1 commit into from
Sep 10, 2024
Merged

refactor(ios): add a uiManager getter for UIView #4022

merged 1 commit into from
Sep 10, 2024

Conversation

wwwcg
Copy link
Collaborator

@wwwcg wwwcg commented Sep 10, 2024

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@wwwcg wwwcg requested a review from ruifanyuan as a code owner September 10, 2024 10:09
@github-actions github-actions bot added renderer: native size: m Denotes a PR that changes 100-499 lines labels Sep 10, 2024
@hippy-service Hippy Service
Copy link

hippy-service bot commented Sep 10, 2024

Hi, @wwwcg. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@wwwcg
refactor(ios): add a uiManager getter for UIView
4e3b00e 
For compatibility,
some third-party components want to get UIManager
or HippyBridge directly through UIView,
although there is a slight performance penalty doing this.
@wwwcg wwwcg merged commit e5fcf2f into Tencent:main Sep 10, 2024
19 of 22 checks passed
wwwcg added a commit to wwwcg/Hippy that referenced this pull request Sep 10, 2024
@wwwcg
refactor(ios): add a uiManager getter for UIView (Tencent#4022)
c933873 
For compatibility,
some third-party components want to get UIManager
or HippyBridge directly through UIView,
although there is a slight performance penalty doing this.
wwwcg added a commit to wwwcg/Hippy that referenced this pull request Sep 13, 2024
@wwwcg
refactor(ios): add a uiManager getter for UIView (Tencent#4022)
5c58119 
For compatibility,
some third-party components want to get UIManager
or HippyBridge directly through UIView,
although there is a slight performance penalty doing this.
wwwcg added a commit that referenced this pull request Sep 13, 2024
@wwwcg
refactor(ios): add a uiManager getter for UIView (#4022)
7870ddd 
For compatibility,
some third-party components want to get UIManager
or HippyBridge directly through UIView,
although there is a slight performance penalty doing this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruifanyuan ruifanyuan Awaiting requested review from ruifanyuan ruifanyuan is a code owner

Assignees
No one assigned
Labels
renderer: native size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wwwcg