Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): fix object_data_map crash when jsc_vm and jsc_ctx released … #4017

Merged
merged 1 commit into from
Sep 4, 2024
Merged

fix(ios): fix object_data_map crash when jsc_vm and jsc_ctx released … #4017

merged 1 commit into from
Sep 4, 2024

Conversation

etkmao
Copy link
Collaborator

@etkmao etkmao commented Sep 4, 2024

…in 2 threads

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@etkmao etkmao requested a review from ilikethese as a code owner September 4, 2024 12:22
@etkmao etkmao requested a review from wwwcg September 4, 2024 12:23
@github-actions github-actions bot added the size: s Denotes a PR that changes 10-99 lines label Sep 4, 2024
@hippy-service Hippy Service
Copy link

hippy-service bot commented Sep 4, 2024

Hi, @etkmao. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@etkmao etkmao force-pushed the bugfix/object_data_map_crash branch from 8c871e9 to 7dbc124 Compare September 4, 2024 12:42
wwwcg
wwwcg approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@wwwcg wwwcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wwwcg wwwcg merged commit bfbb6f9 into Tencent:main Sep 4, 2024
19 of 22 checks passed
wwwcg pushed a commit to wwwcg/Hippy that referenced this pull request Sep 4, 2024
@etkmao @wwwcg
fix(ios): fix object_data_map crash (Tencent#4017)
5aa6173 
when jsc_vm released before jsc_ctx
wwwcg pushed a commit to wwwcg/Hippy that referenced this pull request Sep 10, 2024
@etkmao @wwwcg
fix(ios): fix object_data_map crash (Tencent#4017)
b8b5fd6 
when jsc_vm released before jsc_ctx
wwwcg pushed a commit to wwwcg/Hippy that referenced this pull request Sep 10, 2024
@etkmao @wwwcg
fix(ios): fix object_data_map crash (Tencent#4017)
5128054 
when jsc_vm released before jsc_ctx
wwwcg pushed a commit to wwwcg/Hippy that referenced this pull request Sep 13, 2024
@etkmao @wwwcg
fix(ios): fix object_data_map crash (Tencent#4017)
a7f630f 
when jsc_vm released before jsc_ctx
wwwcg pushed a commit that referenced this pull request Sep 13, 2024
@etkmao @wwwcg
fix(ios): fix object_data_map crash (#4017)
ac1e4b9 
when jsc_vm released before jsc_ctx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwwcg wwwcg wwwcg approved these changes

@ilikethese ilikethese Awaiting requested review from ilikethese ilikethese is a code owner

Assignees
No one assigned
Labels
driver: js size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etkmao @wwwcg