Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix local ref overflow in convert_utils #3901

Closed
wants to merge 3 commits into from
Closed

fix local ref overflow in convert_utils #3901

wants to merge 3 commits into from

Conversation

1780243524
Copy link
Contributor

@1780243524 1780243524 commented Jun 12, 2024 •
edited
Loading

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@tencent-adm
Copy link
Member

tencent-adm commented Jun 12, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the size: s Denotes a PR that changes 10-99 lines label Jun 12, 2024
@hippy-service Hippy Service
Copy link

hippy-service bot commented Jun 12, 2024

Hi, @1780243524. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@1780243524
Copy link
Contributor Author

1780243524 commented Jun 12, 2024 via email

@hippy-service Hippy Service
Copy link

hippy-service bot commented Jun 12, 2024

After a quick scan, I have approved workflow to run.

🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators.
🏷️ No need to worry about the status of merge_guard and [gh] pull request merge guard / merge_guard (pull_request_target) checks, once this pull request is met merge requirements, it will be automatically converted to successful status.

etkmao
etkmao reviewed Jun 13, 2024
View reviewed changes
android/sdk/src/main/jni/src/jni/convert_utils.cc Outdated
@@ -346,7 +347,9 @@ std::tuple<bool, std::string, jobject> ConvertUtils::ToHippyMap(const std::share
j_env->DeleteLocalRef(key_j_obj);
j_env->DeleteLocalRef(value_j_obj);
}
return std::make_tuple(true, "", obj);
auto tuple = std::make_tuple(true, "", obj);
j_env->DeleteLocalRef(obj);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obj外面用，别deleteRef

android/sdk/src/main/jni/src/jni/convert_utils.cc Outdated
@@ -366,7 +369,9 @@ std::tuple<bool, std::string, jobject> ConvertUtils::ToHippyArray(const std::sha
JNIEnvironment::ClearJEnvException(j_env);
j_env->DeleteLocalRef(j_obj);
}
return std::make_tuple(true, "", obj);
auto tuple = std::make_tuple(true, "", obj);
j_env->DeleteLocalRef(obj);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

问题同上

android/sdk/src/main/jni/src/jni/convert_utils.cc Outdated
return std::make_tuple(true, "", result);
auto tuple = std::make_tuple(true, "", result);
if (result) {
env->DeleteLocalRef(result);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

问题同上

@github-actions github-actions bot added size: xs Denotes a PR that changes 0-9 lines and removed size: s Denotes a PR that changes 10-99 lines labels Jun 13, 2024
@hippy-service Hippy Service
Copy link

hippy-service bot commented Jun 13, 2024

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@hippy-service Hippy Service
Copy link

hippy-service bot commented Jun 13, 2024

After a quick scan, I have approved workflow to run.

@1780243524 1780243524 closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etkmao etkmao etkmao approved these changes

@ilikethese ilikethese Awaiting requested review from ilikethese ilikethese is a code owner

Assignees
No one assigned
Labels
framework: android size: xs Denotes a PR that changes 0-9 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1780243524 @tencent-adm @etkmao