Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/3.0 upgrade guidelines #3805

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

siguangli
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@siguangli siguangli requested a review from zealotchen0 as a code owner April 1, 2024 12:50
@github-actions github-actions bot added doc: pages size: xl Denotes a PR that changes 1000+ lines labels Apr 1, 2024
Copy link

hippy-service bot commented Apr 1, 2024

Hi, @siguangli. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

Copy link

hippy-service bot commented Apr 1, 2024

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@siguangli siguangli added the action(squash-merge) Squash and merge action label Apr 1, 2024
Copy link

hippy-actions bot commented Apr 1, 2024

⚠️ squash-merge action execution failed, because of pull request title does not meet the Convention Commit guideline.

Please check the following details:

⧗   input: Feat/3.0 upgrade guidelines
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]
✖   header subject cannot be empty [function-rules/header-min-length]
✖   scope may not be empty [scope-empty]

✖   found 4 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

@siguangli

@hippy-actions hippy-actions bot added action(squash-merge): failed Squash and merge action execution failed and removed action(squash-merge) Squash and merge action labels Apr 1, 2024
@siguangli siguangli merged commit 4ac9966 into Tencent:main Apr 1, 2024
49 checks passed
@siguangli siguangli deleted the feat/3.0_Upgrade_Guidelines branch April 1, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action(squash-merge): failed Squash and merge action execution failed doc: pages size: xl Denotes a PR that changes 1000+ lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants