Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): fix conversion crash from oc object to CtxValue #3802

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

wwwcg
Copy link
Collaborator

@wwwcg wwwcg commented Mar 28, 2024

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@github-actions github-actions bot added framework: ios driver: js size: m Denotes a PR that changes 100-499 lines labels Mar 28, 2024
Copy link

hippy-service bot commented Mar 28, 2024

Hi, @wwwcg. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

etkmao
etkmao previously approved these changes Mar 28, 2024
@etkmao etkmao self-requested a review March 28, 2024 14:18
Copy link

hippy-service bot commented Mar 29, 2024

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Mar 29, 2024
@hippy-actions hippy-actions bot enabled auto-merge (rebase) March 29, 2024 03:53
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Mar 29, 2024
@wwwcg wwwcg disabled auto-merge March 29, 2024 09:09
@wwwcg wwwcg merged commit 11ebce7 into Tencent:main Mar 29, 2024
20 of 23 checks passed
@wwwcg wwwcg deleted the hippy3_fix_0328_2 branch March 29, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
driver: js framework: ios size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants