Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): ensure insertHippySubview is called sequentially #3786

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

wwwcg
Copy link
Collaborator

@wwwcg wwwcg commented Mar 21, 2024

Some businesses depend on the invocation order of the insertHippySubview method,
so we use std::map instead to ensure that the view created first calls that method first

Some businesses depend on the invocation order of the insertHippySubview method,
so we use std::map instead to ensure that the view created first calls that method first
@wwwcg wwwcg requested a review from ruifanyuan as a code owner March 21, 2024 03:26
@github-actions github-actions bot added renderer: native size: xs Denotes a PR that changes 0-9 lines labels Mar 21, 2024
Copy link

hippy-service bot commented Mar 21, 2024

Hi, @wwwcg. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

Copy link

hippy-service bot commented Mar 26, 2024

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Mar 26, 2024
@hippy-actions hippy-actions bot enabled auto-merge (rebase) March 26, 2024 03:56
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Mar 26, 2024
@hippy-actions hippy-actions bot merged commit 6ce3776 into Tencent:main Mar 26, 2024
19 checks passed
@wwwcg wwwcg deleted the hippy3_fix_0321_2 branch March 26, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
renderer: native size: xs Denotes a PR that changes 0-9 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants