Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/fix voltron remote server url parse #3722

Closed
wants to merge 7 commits into from
Closed

fix/fix voltron remote server url parse #3722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3a76e4f
fix(voltron): resolve remoteServerUrl parse version id failed
lvfen Jan 16, 2024
be53681
fix(voltron): add license for flutter_render_test.dart
lvfen Jan 16, 2024
8c00fe2
fix(voltron): remoteServerUrl connect without path
lvfen Jan 17, 2024
a5fd41c
fix(voltron): remoteServerUrl connect without path
lvfen Jan 17, 2024
9a216a3
fix(voltron): remoteServerUrl connect without path
lvfen Jan 17, 2024
c44acb2
Merge branch 'main' into fix/fix_voltron_remote_server_url_parse
lvfen Jan 17, 2024
02b316f
Merge branch 'main' into fix/fix_voltron_remote_server_url_parse
lvfen Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions framework/voltron/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.0.39

- resolve remoteServerUrl connect without '/'

## 0.0.38

- resolve remoteServerUrl parse version id failed
Expand Down
2 changes: 1 addition & 1 deletion framework/voltron/lib/inspector/dev_server_helper.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class DevServerHelper {
bool jsMinify,
) {
if (_remoteServerData.isValid()) {
return "${_remoteServerData.getScheme()}://${_remoteServerData.getHost()}${_remoteServerData.getPath()}?dev=$devMode&hot=$hmr&minify=$jsMinify";
return "${_remoteServerData.getScheme()}://${_remoteServerData.getHost()}/${_remoteServerData.getPath()}?dev=$devMode&hot=$hmr&minify=$jsMinify";
}
return "http://$host/$bundleName?dev=$devMode&hot=$hmr&minify=$jsMinify";
}
Expand Down
2 changes: 1 addition & 1 deletion framework/voltron/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

name: voltron
description: A flutter plugin project to render hippy page.
version: 0.0.38
version: 0.0.39
homepage: https://hippyjs.org
repository: https://github.com/Tencent/Hippy

Expand Down
Loading