Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): update props reuse null view object #3566

Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix(android): update props reuse null view object #3566

merged 1 commit into from
Oct 25, 2023

Conversation

siguangli
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@siguangli siguangli requested a review from iPel as a code owner October 25, 2023 13:26
@github-actions github-actions bot added renderer: native size: s Denotes a PR that changes 10-99 lines labels Oct 25, 2023
@hippy-service
Copy link

hippy-service bot commented Oct 25, 2023

Hi, @siguangli. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@siguangli siguangli merged commit a45eda0 into Tencent:main Oct 25, 2023
30 checks passed
@siguangli siguangli deleted the fix/updateProps branch October 25, 2023 13:29
@hippy-service
Copy link

hippy-service bot commented Oct 25, 2023

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Oct 25, 2023
@hippy-actions
Copy link

hippy-actions bot commented Oct 25, 2023

⚠️ rebase-merge action execution failed, because of auto rebase and merge failed.

Please check the following details:

GraphQL: Can't disable auto-merge for this pull request. (disablePullRequestAutoMerge)

#help

@hippy-actions hippy-actions bot added action(rebase-merge): failed Rebase and merge action execution failed and removed action(rebase-merge) Rebase and merge action (maybe privileged) labels Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iPel iPel iPel approved these changes

Assignees
No one assigned
Labels
action(rebase-merge): failed Rebase and merge action execution failed renderer: native size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siguangli @iPel @siguangli2018