Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): relayout dom when rootView frame change #3559

Merged
merged 2 commits into from
Oct 23, 2023
Merged

fix(ios): relayout dom when rootView frame change #3559

merged 2 commits into from
Oct 23, 2023

Conversation

wwwcg
Copy link
Collaborator

@wwwcg wwwcg commented Oct 20, 2023

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@wwwcg wwwcg requested a review from ruifanyuan as a code owner October 20, 2023 11:14
@github-actions github-actions bot added framework: ios renderer: native size: s Denotes a PR that changes 10-99 lines labels Oct 20, 2023
@hippy-service
Copy link

hippy-service bot commented Oct 20, 2023

Hi, @wwwcg. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@wwwcg wwwcg force-pushed the fix/hippy3_rootView branch from c2a2353 to d924aa6 Compare October 20, 2023 11:59
ruifanyuan
ruifanyuan previously approved these changes Oct 23, 2023
View reviewed changes
framework/ios/base/bridge/HippyBridge.mm Outdated Show resolved Hide resolved
@hippy-service
Copy link

hippy-service bot commented Oct 23, 2023

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Oct 23, 2023
@hippy-actions hippy-actions bot enabled auto-merge (rebase) October 23, 2023 10:15
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Oct 23, 2023
@wwwcg wwwcg force-pushed the fix/hippy3_rootView branch from b6b479c to 1846921 Compare October 23, 2023 11:51
@wwwcg wwwcg requested a review from ruifanyuan October 23, 2023 11:52
@hippy-service
Copy link

hippy-service bot commented Oct 23, 2023

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Oct 23, 2023
@hippy-actions hippy-actions bot disabled auto-merge October 23, 2023 11:59
@hippy-actions hippy-actions bot enabled auto-merge (rebase) October 23, 2023 11:59
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Oct 23, 2023
@hippy-actions hippy-actions bot merged commit e7820f9 into Tencent:main Oct 23, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruifanyuan ruifanyuan ruifanyuan approved these changes

Assignees
No one assigned
Labels
doc: example framework: ios renderer: native size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wwwcg @ruifanyuan @open-hippy