Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dom): remove dom value #3460

Merged
merged 5 commits into from
Aug 29, 2023
Merged

feat(dom): remove dom value #3460

merged 5 commits into from
Aug 29, 2023

Conversation

ilikethese
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@hippy-service
Copy link

hippy-service bot commented Aug 25, 2023

Hi, @ilikethese. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@github-actions github-actions bot added the size: l Denotes a PR that changes 500-999 lines label Aug 25, 2023
lavnFan
lavnFan previously approved these changes Aug 25, 2023
View reviewed changes
ozonelmy
ozonelmy previously approved these changes Aug 25, 2023
View reviewed changes
etkmao
etkmao previously approved these changes Aug 25, 2023
View reviewed changes
skindhu
skindhu previously approved these changes Aug 25, 2023
View reviewed changes
vimerzhao
vimerzhao previously approved these changes Aug 25, 2023
View reviewed changes
siguangli
siguangli previously approved these changes Aug 25, 2023
View reviewed changes
@hippy-service
Copy link

hippy-service bot commented Aug 25, 2023

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Aug 25, 2023
@hippy-actions hippy-actions bot enabled auto-merge (rebase) August 25, 2023 08:11
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Aug 25, 2023
lvfen
lvfen previously approved these changes Aug 28, 2023
View reviewed changes
@hippy-service
Copy link

hippy-service bot commented Aug 28, 2023

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Aug 28, 2023
@hippy-actions hippy-actions bot disabled auto-merge August 28, 2023 12:35
@hippy-actions hippy-actions bot enabled auto-merge (rebase) August 28, 2023 12:35
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Aug 28, 2023
iPel
iPel previously approved these changes Aug 28, 2023
View reviewed changes
wwwcg
wwwcg previously approved these changes Aug 28, 2023
View reviewed changes
@hippy-actions hippy-actions bot merged commit d2efeda into Tencent:main Aug 29, 2023
24 checks passed
@hippy-service
Copy link

hippy-service bot commented Aug 29, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etkmao etkmao etkmao approved these changes

@vimerzhao vimerzhao vimerzhao approved these changes

@lavnFan lavnFan lavnFan approved these changes

@lvfen lvfen lvfen approved these changes

@wwwcg wwwcg wwwcg approved these changes

@iPel iPel iPel approved these changes

@siguangli siguangli siguangli left review comments

@ozonelmy ozonelmy ozonelmy left review comments

@skindhu skindhu skindhu left review comments

Assignees
No one assigned
Labels
devtools: backend dom: animation dom: tree driver: js framework: voltron module: footstone module: ios renderer: native renderer: tdf size: l Denotes a PR that changes 500-999 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.