feat(hippy-react): modal visible default true and optional props #3446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomdyqin
requested review from
zealotchen0,
churchill-zhang,
ilikethese,
ozonelmy,
wwwcg,
siguangli and
pba-cra
as code owners
tomdyqin
changed the title
github-actions
bot
added
driver: js
size: xs
github-actions
bot
added
size: s
zealotchen0
approved these changes
Aug 28, 2023
| repeatCount: number; | ||
| virtual: any; // TODO: What's it? | ||
| repeatCount: number | 'loop'; | ||
| virtual?: any; // TODO: What's it? |
|
🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.
|
|
After a quick scan, I have approved workflow to run.
|
zealotchen0
pushed a commit
that referenced
this pull request
Aug 28, 2023
* fix(hippy-react): modal visible default true and optional props * fix(hippy-react): repeatCount can be 'loop' * fix(hippy-react): fix ts declaration * fix(hippy-react): borderStyle can be none * fix(hippy-react): flex can be number% * fix(hippy-react-web): flex style declaration * fix(hippy-react): remove unused virtual --------- Co-authored-by: OpenHippy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a new pull request, please make sure: