Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/image data key #3441

Merged
merged 9 commits into from
Aug 17, 2023
Merged

Fix/image data key #3441

merged 9 commits into from
Aug 17, 2023

Conversation

siguangli
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@hippy-service
Copy link

hippy-service bot commented Aug 17, 2023

Hi, @siguangli. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@zealotchen0 zealotchen0 added the action(rebase-merge) Rebase and merge action (maybe privileged) label Aug 17, 2023
@hippy-actions hippy-actions bot enabled auto-merge (rebase) August 17, 2023 03:05
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Aug 17, 2023
@hippy-service
Copy link

hippy-service bot commented Aug 17, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@siguangli siguangli added the action(rebase-merge) Rebase and merge action (maybe privileged) label Aug 17, 2023
@hippy-actions hippy-actions bot disabled auto-merge August 17, 2023 03:07
@hippy-actions hippy-actions bot enabled auto-merge (rebase) August 17, 2023 03:07
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Aug 17, 2023
@hippy-actions hippy-actions bot merged commit e55641e into Tencent:main Aug 17, 2023
42 of 44 checks passed
@siguangli siguangli deleted the fix/ImageDataKey branch August 17, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zealotchen0 zealotchen0 zealotchen0 approved these changes

@ilikethese ilikethese Awaiting requested review from ilikethese

Assignees
No one assigned
Labels
doc: example doc: pages framework: android module: android renderer: native size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siguangli @zealotchen0 @siguangli2018