Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignoreForClass attribute that aborts contextmenu if applied #101

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

felixruponen
Copy link
Contributor

  • If the element has the ignoreForClass the context menu won't be shown

This adds ability to dynamically disable contextMenu

Example:

If the div has "some-class" the context-menu won't show.

Felix Ruponen added 2 commits February 14, 2017 13:19
* If the element has the ignoreForClass the context menu won't be shown
@josetaira
Copy link
Collaborator

josetaira commented Feb 16, 2017

I'm not sure using a class to disable this is the way to go. The more appropriate way to do so appears to just set a flag through an attribute like context-menu-enabled. Then this flagged is set by the controller based on some parameters, in this case the class.

@Templarian not sure if this is something we should merge in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants