Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bella Italia – Order your pizza here #146

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

HeleneWestrin
Copy link

Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice job with this project 🍕

JavaScript

  • Really nice to check for edge cases, like if the user doesn't input a name (if (!userName) { userName = "Anonymous"; }). Great job considering that!
  • You've done well using control flow statements like do...while as well as if...else and switch to handle user inputs for food selection ⭐
  • In script.js, you're using the .toLowerCase() method to handle user input flexibly when confirming their order. Nice use of string manipulation!
  • One suggestion is regarding age validation. In the current code, the check for age doesn't account for invalid (non-number) inputs properly:
let pizzaSize = prompt(`Is the pizza for an adult or a child? Please enter your age.`);
if (Number(pizzaSize) >= 12) {

It would be good to handle cases where the input is not a valid number by adding a check before converting to a number. You could use:

if (!isNaN(pizzaSize) && Number(pizzaSize) >= 12) { ... }

This way, you can avoid invalid entries crashing your logic.

Also, very nice with a start function ⭐ Keep up the good work Helene!

@HeleneWestrin
Copy link
Author

Thank you @HIPPIEKICK! 🤗

Ohh, great advice! I will look into fixing that 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants