Add ghactions support #118
Conversation
4ver
commented
Dec 6, 2023
4ver
commented
- Target platforms this affects (Linux, Mac, Mac app store, and or Windows):
- What problem does this solve?
- Could it break any existing functionality for users?
Also only on push
|
"coffee-script" module must be updated to "coffeescript" (it was renamed) with recent versions. This should allow to run tests with Node.js 8 and 14. However, for Node.js 4, I see this that probably needs to be fixed or telling us we shouldn't support Node.js 4: npm WARN engine [email protected]: wanted: {"node":">=6.0.0"} (current: {"node":"4.9.1","npm":"2.15.11"}) |
|
Also, I would suggest to test against LTS releases that are still supported or the ones that were last pushed out of maintenance. This means 16, 18 and 20. |
|
gulp-coffeelint has not been updated for the last 8 years and still depends on "coffee-script" (with a "-")... |
Oxalin
dismissed
their stale review
I wanted to approve a commit, not the series.
|
Also, for Node >= 10, we need to move to gulp 4 (that is why I had the "natives" modules in my commit series because it was a workaround that some people had identified) and update whatever needs to be updated: https://davidsekar.com/nodejs/upgrading-your-gulp-for-running-with-node-v10 |
|
We seem to have a problem under macOS where the CI testing fails to .enable() autolaunch Calculator, and thus fails to disable it. Was it passing before? |
.github/workflows/ci.yaml
Outdated
| jobs: | ||
| build: | ||
| strategy: | ||
| matrix: | ||
| os: [macos-latest, windows-latest, ubuntu-latest] | ||
| node-version: ["0.12", "4.9", "8.17", "14.0"] | ||
| node-version: ["4", "8", "14"] |
There was a problem hiding this comment.
Drop 4 and 8 at least and add 18 and 20 instead. I don't know about 14, it doesn't receive security support anymore since last April. And for the missing 16, it doesn't receive security support either since last September, but it's the last LTS version out the door, so I don't know. Maybe add it for now.
Fix conflicts between branches. Signed-off-by: Alexandre Demers <[email protected]>
This was working on older versions of macos afaik. In more recent versions only the Launch Agent way works. |
|
Not sure it was a good idea to merge this as the tests aren't passing 😅 |
I though it was already failing prior to your PR. My bad. I'll review your new PR. |
