Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'Is not Looped' to 'Do not loop' in ambient_generic #260

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

electrovoyage
Copy link
Contributor

Rename looping flag in ambient_generic to a more readable variant

@vrad-exe
Copy link
Collaborator

This probably isn't a good idea, because the flag doesn't actually control whether or not the sound loops, that's defined in the sound file itself. It just changes the behavior of certain entity inputs and not having it match the sound's inbuilt loop state can cause issues. (FYI, ambient_generic is an absolutely terrible entity, just look at how many bugs are listed on the VDC page.)

@TeamSpen210
Copy link
Owner

Ideally we should find a non-negated wording too...

@electrovoyage
Copy link
Contributor Author

Ideally we should find a non-negated wording too...

I wonder if it's possible to invert the flag in FGD or at least in the Postcompiler?

@electrovoyage
Copy link
Contributor Author

This probably isn't a good idea, because the flag doesn't actually control whether or not the sound loops, that's defined in the sound file itself.

Yes, but HA can pack files, it's probably not hard to make it add loop markers into files (hopefully).
Maybe then the flag can be renamed to something like 'disallow looping'?

@vrad-exe
Copy link
Collaborator

That would be useful, but should be done by adding a new keyvalue to the entity instead of modifying the behavior of an existing flag.

@electrovoyage
Copy link
Contributor Author

electrovoyage commented Mar 28, 2024

...but should be done by adding a new keyvalue to the entity instead of modifying the behavior of an existing flag.

Oh yeah, i completely forgot how flags work

TeamSpen210 added a commit that referenced this pull request Mar 31, 2024
This makes them less confusing, and also allows setting them with $fixup variables.
See #260.
TeamSpen210 added a commit that referenced this pull request Apr 1, 2024
This makes them less confusing, and also allows setting them with $fixup variables.
See #260.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants