Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Cali Offsets instantly #36

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

samuelballantyne
Copy link
Contributor

This pull request addresses an issue where calibration values do not update immediately after the trigger is pulled during the calibration process.

Calibration points are updated as soon as the trigger is pulled.
Calibration Offsets are now set as soon as you pull the trigger.
Copy link
Member

@SeongGino SeongGino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but just one little thing I had a thought about.

SamcoEnhanced/SamcoEnhanced.ino Outdated Show resolved Hide resolved
This pull request addresses an issue where calibration values do not update immediately after the trigger is pulled during the calibration process.
Copy link
Member

@SeongGino SeongGino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! <3

@SeongGino SeongGino merged commit 36ffc18 into TeamOpenFIRE:OpenFIRE-dev Nov 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants