[MediaCCC] Apply changes in extractor tests

Also remove some public test methods modifiers.
TeamNewPipe · Aug 12, 2023 · 1e6c8b7 · 1e6c8b7
1 parent 1a19012
commit 1e6c8b7
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 24 deletions.
diff --git a/...java/org/schabi/newpipe/extractor/services/media_ccc/MediaCCCConferenceExtractorTest.java b/...java/org/schabi/newpipe/extractor/services/media_ccc/MediaCCCConferenceExtractorTest.java
@@ -9,6 +9,7 @@
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.schabi.newpipe.extractor.ExtractorAsserts.assertContainsImageUrlInImageCollection;
 import static org.schabi.newpipe.extractor.ServiceList.MediaCCC;
 
 /**
@@ -30,27 +31,29 @@ public static void setUpClass() throws Exception {
         }
 
         @Test
-        public void testName() throws Exception {
+        void testName() throws Exception {
             assertEquals("FrOSCon 2017", extractor.getName());
         }
 
         @Test
-        public void testGetUrl() throws Exception {
+        void testGetUrl() throws Exception {
             assertEquals("https://media.ccc.de/c/froscon2017", extractor.getUrl());
         }
 
         @Test
-        public void testGetOriginalUrl() throws Exception {
+        void testGetOriginalUrl() throws Exception {
             assertEquals("https://media.ccc.de/c/froscon2017", extractor.getOriginalUrl());
         }
 
         @Test
-        public void testGetThumbnailUrl() throws Exception {
-            assertEquals("https://static.media.ccc.de/media/events/froscon/2017/logo.png", extractor.getAvatarUrl());
+        void testGetThumbnails() {
+            assertContainsImageUrlInImageCollection(
+                    "https://static.media.ccc.de/media/events/froscon/2017/logo.png",
+                    extractor.getAvatars());
         }
 
         @Test
-        public void testGetInitalPage() throws Exception {
+        void testGetInitalPage() throws Exception {
             assertEquals(97, tabExtractor.getInitialPage().getItems().size());
         }
     }
@@ -70,27 +73,29 @@ public static void setUpClass() throws Exception {
         }
 
         @Test
-        public void testName() throws Exception {
+        void testName() throws Exception {
             assertEquals("Open Source Conference Albania 2019", extractor.getName());
         }
 
         @Test
-        public void testGetUrl() throws Exception {
+        void testGetUrl() throws Exception {
             assertEquals("https://media.ccc.de/c/oscal19", extractor.getUrl());
         }
 
         @Test
-        public void testGetOriginalUrl() throws Exception {
+        void testGetOriginalUrl() throws Exception {
             assertEquals("https://media.ccc.de/c/oscal19", extractor.getOriginalUrl());
         }
 
         @Test
-        public void testGetThumbnailUrl() throws Exception {
-            assertEquals("https://static.media.ccc.de/media/events/oscal/2019/oscal-19.png", extractor.getAvatarUrl());
+        void testGetThumbnailUrl() {
+            assertContainsImageUrlInImageCollection(
+                    "https://static.media.ccc.de/media/events/oscal/2019/oscal-19.png",
+                    extractor.getAvatars());
         }
 
         @Test
-        public void testGetInitalPage() throws Exception {
+        void testGetInitalPage() throws Exception {
             assertTrue(tabExtractor.getInitialPage().getItems().size() >= 21);
         }
     }

diff --git a/...est/java/org/schabi/newpipe/extractor/services/media_ccc/MediaCCCStreamExtractorTest.java b/...est/java/org/schabi/newpipe/extractor/services/media_ccc/MediaCCCStreamExtractorTest.java
@@ -21,6 +21,7 @@
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.schabi.newpipe.extractor.ExtractorAsserts.assertContainsImageUrlInImageCollection;
 import static org.schabi.newpipe.extractor.ServiceList.MediaCCC;
 
 /**
@@ -66,16 +67,20 @@ public static void setUp() throws Exception {
 
         @Override
         @Test
-        public void testThumbnailUrl() throws Exception {
-            super.testThumbnailUrl();
-            assertEquals("https://static.media.ccc.de/media/events/gpn/gpn18/105-hd.jpg", extractor.getThumbnailUrl());
+        public void testThumbnails() throws Exception {
+            super.testThumbnails();
+            assertContainsImageUrlInImageCollection(
+                    "https://static.media.ccc.de/media/events/gpn/gpn18/105-hd_preview.jpg",
+                    extractor.getThumbnails());
         }
 
         @Override
         @Test
-        public void testUploaderAvatarUrl() throws Exception {
-            super.testUploaderAvatarUrl();
-            assertEquals("https://static.media.ccc.de/media/events/gpn/gpn18/logo.png", extractor.getUploaderAvatarUrl());
+        public void testUploaderAvatars() throws Exception {
+            super.testUploaderAvatars();
+            assertContainsImageUrlInImageCollection(
+                    "https://static.media.ccc.de/media/events/gpn/gpn18/logo.png",
+                    extractor.getUploaderAvatars());
         }
 
         @Override
@@ -140,16 +145,20 @@ public static void setUp() throws Exception {
 
         @Override
         @Test
-        public void testThumbnailUrl() throws Exception {
-            super.testThumbnailUrl();
-            assertEquals("https://static.media.ccc.de/media/congress/2019/10565-hd.jpg", extractor.getThumbnailUrl());
+        public void testThumbnails() throws Exception {
+            super.testThumbnails();
+            assertContainsImageUrlInImageCollection(
+                    "https://static.media.ccc.de/media/congress/2019/10565-hd_preview.jpg",
+                    extractor.getThumbnails());
         }
 
         @Override
         @Test
-        public void testUploaderAvatarUrl() throws Exception {
-            super.testUploaderAvatarUrl();
-            assertEquals("https://static.media.ccc.de/media/congress/2019/logo.png", extractor.getUploaderAvatarUrl());
+        public void testUploaderAvatars() throws Exception {
+            super.testUploaderAvatars();
+            assertContainsImageUrlInImageCollection(
+                    "https://static.media.ccc.de/media/congress/2019/logo.png",
+                    extractor.getUploaderAvatars());
         }
 
         @Override