Migrate to Coil 3 #11723
Merged
Migrate to Coil 3 #11723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isira-Seneviratne
force-pushed
the
Coil-3
branch
2 times, most recently
from
dd7ca1a
to
341386c
Compare
Isira-Seneviratne
force-pushed
the
Coil-3
branch
from
341386c
to
ca855cb
Compare
ShareASmile
added
dependency
Profpatsch
approved these changes
Nov 20, 2024
|
I think you have to run the auto-formatter on the .kt file, otherwise the linter fails |
TobiGr
reviewed
Nov 20, 2024
Co-authored-by: Tobi <[email protected]>
Stypox
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
I tested the following things and everything worked well:
- clearing cache actually removes the files on disk
- the player thumbnail loads normally (also in SoundCloud songs)
- the notification thumbnail also loads fine
- changing image quality works
- sharing a video also shows its image in the share sheet, so the image is correctly obtained from cache
Thank you!
app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
ImageLoader.Builderbeing converted to extension functions.Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence