-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate build to version catalogs #11684
Conversation
Thanks for the PR! This should go to the |
9629362
to
a073fdd
Compare
Okay, so I checked this out, squashed the last 3 commits into one, and I have to say I’m not particularly in favor of this. Before, we had a pretty simple file with dependencies and their version numbers, now we have yet another toml file, and that file has yet another indirection, so we are introducing two indirections here for very little gain. I’m in favor of closing this PR and the referenced issue as WONTDO |
I’d be okay with merging the change @JL0000 if you can clean up the history, squash everything into one commit and make it compatible with the current refactor branch. |
@JL0000 It seems like the PR contains a lot of unrelated commits, likely due to updating the base branch on GitHub. To resolve this, you can rebase your branch locally onto the latest |
a073fdd
to
5d82948
Compare
@JL0000 Thanks for updating. I will review the changes today. |
5d82948
to
de5d458
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @JL0000, for implementing the changes. I have updated the naming for a few libraries, and the changes look good to me.
One suggestion: I wonder if we could implement a system to enforce or lint this file to ensure the list remains sorted. If this proves too complex, we could address it in a separate ticket.
Quality Gate passedIssues Measures |
What is it?
Description of the changes in your PR
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence