Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Search Shortcuts Feature #7686 #11649

Closed

Conversation

7084054
Copy link

@7084054 7084054 commented Oct 27, 2024

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • I DON'T INTEND TO MAINTAIN THIS

  • made changes to database (adding in new bookmark column)
  • changes to search order priority to prioritise shortcut searches
  • added onclick on left search icon to shortcut or Un shortcut search.
  • tap on search history icon to use.

Before/After Screenshots/Screen Record

  • Before:
    image showing search
  • After:
    image showing search shortcut after search history icon clicked on
    tapped on search history icon.

Fixes the following issue(s)

APK testing

  • Installed the APK on the emulator running Android 13.
  • Verified the adding and removing of shortcuts on empty and non-empty strings.
  • Ensured the bookmarks remain after opening and closing app.
  • Confirmed no crashes or unexpected behaviour during testing.

Due diligence

@github-actions github-actions bot added the size/giant PRs with more than 750 changed lines label Oct 27, 2024
@ShareASmile ShareASmile changed the title Search Shortcuts Feature #7686 Add Search Shortcuts Feature #7686 Oct 27, 2024
@ShareASmile ShareASmile added feature request Issue is related to a feature in the app search Anything related to the search function labels Oct 27, 2024
Copy link

sonarcloud bot commented Oct 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@TobiGr
Copy link
Member

TobiGr commented Oct 27, 2024

Thank you for your PR. Due to the influx of new PRs review might take some time. Please let me know if you are an ANU student for internal statistics and because I am writing my master thesis about open source contributions as part of learning computer science and computer science education at university.

@7084054
Copy link
Author

7084054 commented Oct 27, 2024

Hi @TobiGr,
I'm an ANU student.

@Stypox
Copy link
Member

Stypox commented Nov 12, 2024

NewPipe is currently in maintenance mode and is not accepting PRs for new features, as explained on top of the README, especially features like this one that can possibly break other things in case a bug slips through, and also considering the fact that you don't want to maintain this feature.

Thank you anyway for your contribution!

@Stypox Stypox closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app search Anything related to the search function size/giant PRs with more than 750 changed lines
Projects
No open projects
Status: Rejected
Development

Successfully merging this pull request may close these issues.

Search shortcuts
4 participants