Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grey out watched videos #11625

Closed
wants to merge 2 commits into from
Closed

Conversation

yy-385
Copy link

@yy-385 yy-385 commented Oct 20, 2024

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Updated the UI to include a toggle switch in the Audio/Video settings page, allowing users to control the grey-out feature for unwatched videos.
  • Modified the updateFromItem method in the StreamInfoItemHolder class to apply the grey-out logic based on the toggle’s state (on/off).

Before/After Screenshots/Screen Record

  • Before:
Screenshot 2024-10-20 at 10 52 44 pm
  • After:
Screenshot 2024-10-20 at 5 17 04 pm

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

I Tested the APK using the Android Studio Emulator with the following steps:

  1. Installed the APK on the emulator running Android 13.
  2. Verified the toggle in Audio/Video settings enables and disables the grey-out feature correctly.
  3. Checked that the grey-out effect applies to watched videos when the toggle is on.
  4. Ensured the toggle setting persists after restarting the app.
  5. Confirmed no crashes or unexpected behavior during testing.

The feature works as expected in both light and dark modes.

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Oct 20, 2024
@yy-385 yy-385 closed this Oct 20, 2024
@opusforlife2
Copy link
Collaborator

@yy-385 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/small PRs with less than 50 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants