Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose search issue 3475 #11610

Closed

Conversation

jiahengguo123
Copy link

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Exposed a search API via a custom URL scheme: Implemented the ability for third-party apps to initiate a search in NewPipe using a custom URL scheme newpipe://search?q=YOUR_QUERY.
  • Added intent-filter to RouterActivity: Updated AndroidManifest.xml to include an intent-filter in RouterActivity to handle the custom URL scheme.
  • Modified RouterActivity to handle the new intent: Updated RouterActivity to parse incoming intents with the newpipe://search scheme, extract the search query parameter, and start MainActivity with the necessary extras.
  • Tested the implementation: Used ADB commands to send an intent with the custom URI and verified that NewPipe performs the search as expected.

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/medium PRs with less than 250 changed lines label Oct 15, 2024
@ShareASmile
Copy link
Collaborator

ShareASmile commented Oct 20, 2024

@jiahengguo123 why it was closed?

If it was reviewd and approved by @rmtilde as I see here then that is a good reason to keep it open for NewPipe contribution and review process.

Mind you review here can take a long time, I think it should be okay with you.

@ShareASmile ShareASmile reopened this Oct 20, 2024
@ShareASmile
Copy link
Collaborator

ShareASmile commented Oct 20, 2024

Oh.. Your New PR #11615 is there for the same issue, So Closing it.

Sorry for the confusion. I should not triage issues/PRs so early in the morning 😄.

@jiahengguo123
Copy link
Author

This PR closed was because I forgot to do a code review. Sorry if it's confusing.

@opusforlife2
Copy link
Collaborator

@jiahengguo123 This is a collaborative platform, so it is better to state your reason for closing a PR for the sake of future visitors. In general, make your actions less mysterious for others who might come across them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/medium PRs with less than 250 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose search API with url
3 participants