Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gradle #11604

Closed
wants to merge 1 commit into from
Closed

Fix gradle #11604

wants to merge 1 commit into from

Conversation

TobiGr
Copy link
Member

@TobiGr TobiGr commented Oct 10, 2024

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Jitpack is somewhat buggy. See TeamNewPipe/NewPipeExtractor#1066

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@TobiGr TobiGr added the dependency Issues and PRs related to dependencies label Oct 10, 2024
@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Oct 10, 2024
@Stypox
Copy link
Member

Stypox commented Oct 12, 2024

Mmmh, the build is still failing. We should switch away from Jitpack and use a local git build, as I did with Dicio (see here)

@syphyr
Copy link

syphyr commented Oct 19, 2024

I tried this PR and the build is still failing. Although, if I only change this line, then it builds successfully. This build issue seems to be only with NewPipeExtractor.

--- a/app/build.gradle
+++ b/app/build.gradle
@@ -198,7 +198,7 @@ dependencies {
     // name and the commit hash with the commit hash of the (pushed) commit you want to test
     // This works thanks to JitPack: https://jitpack.io/
     implementation 'com.github.TeamNewPipe:nanojson:1d9e1aea9049fc9f85e68b43ba39fe7be1c1f751'
-    implementation 'com.github.TeamNewPipe:NewPipeExtractor:v0.24.2'
+    implementation 'com.github.teamnewpipe:NewPipeExtractor:v0.24.2'
     implementation 'com.github.TeamNewPipe:NoNonsense-FilePicker:5.0.0'
 
 /** Checkstyle **/

@litetex litetex mentioned this pull request Oct 23, 2024
5 tasks
@Stypox
Copy link
Member

Stypox commented Oct 23, 2024

Superseded by #11636

@Stypox Stypox closed this Oct 23, 2024
@TobiGr TobiGr deleted the fix-jitpack branch October 23, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Issues and PRs related to dependencies size/small PRs with less than 50 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants